Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use RabbitMQ vhostName from authParams when declared #6373

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Use RabbitMQ vhostName from authParams when declared #6373

wants to merge 3 commits into from

Conversation

michemache
Copy link

@michemache michemache commented Nov 28, 2024 •
edited by zroubalik
Loading

If the RabbitMQ vhostName is declared in the TriggerAuthentication resource, it will be used.

Checklist

Fixes #6369

@michemache michemache force-pushed the trigger-authentication-vhost-name branch from f908127 to 977de43 Compare November 28, 2024 11:05
@michemache
Update CHANGELOG.md
83d9508 
Signed-off-by: Michi U. <[email protected]>
@michemache michemache force-pushed the trigger-authentication-vhost-name branch from 252008a to 83d9508 Compare November 28, 2024 11:17
@michemache michemache marked this pull request as ready for review November 28, 2024 11:36
@michemache michemache requested a review from a team as a code owner November 28, 2024 11:36
@zroubalik
Copy link
Member

zroubalik commented Dec 4, 2024 •
edited by github-actions bot
Loading

/run-e2e rabbitmq
Update: You can check the progress here

zroubalik
zroubalik approved these changes Dec 4, 2024
View reviewed changes
Copy link
Member

@zroubalik zroubalik left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

docs missing

zroubalik
zroubalik reviewed Dec 4, 2024
View reviewed changes
Copy link
Member

@zroubalik zroubalik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should also update docs

@zroubalik zroubalik self-requested a review December 4, 2024 10:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zroubalik zroubalik Awaiting requested review from zroubalik

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support parameter vhostName in TriggerAuthentication
2 participants
@michemache @zroubalik